[Node] - nvm - fallback to previous version - code fix - #904
Merged
Samruddhi Khandale (samruddhikhandale) merged 2 commits intoMar 12, 2024
Conversation
…g released but binary not found
Samruddhi Khandale (samruddhikhandale)
approved these changes
Mar 12, 2024
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature name:
Description:
This PR introduces the following functionality:
nvmdoesn't have a source binary released yet, then it will continue installing the previous working version for which a source binary will be availableChangelog:
nvmversion is tried to be downloaded with curl command thus representing trying to access a source binary which is not yet deployed bynvm, then will pick up the binary for the tag (previous version) which will eventually work successfully.devcontainer-feature.jsonwith an updated patch version for this feature.Checklist: